Repository navigation
Autonomous: fix PM2 startup, FMU scratch and runner connection leaks - #313
tanushchauhan wants to merge 2 commits into
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 1
Please check the settings in the CodeRabbit UI or the
|
|
Safe to merge. The three fixes do what the PR says, and I found no real problems in this push. What I checkedChecked: I read the whole diff.
Didn't check: I did not run the live HIL, PM2 or Docker acceptance steps, and I did not run Bazel. I also did not run the Node and Python test suites in this pass. The live results rest on the PR description and the runbook. Assumed: I assumed the Ultron reviewed 4a881ef · it re-reviews on new pushes |
Replaces #289 after renaming the source branch to
tanush/deploy-hil-jobs. The previous PR has the review history.What
Fix three failures exposed by the first live deployment: PM2's JavaScript wrapper left the dashboard "online" without starting HTTP, Docker's non-executable scratch prevented FMPy from loading the native FMU, and SQLite transaction contexts leaked connections until the worker exhausted file handles.
Launch Node directly in a single PM2 fork, permit native-library loading only in bounded FMU scratch, and close every database connection after commit/rollback. Add regression tests for all three cases.
Record the operator-approved rollout: dashboard under telemetry's existing
electricPM2 account, restricted accounts/bridge on HIL, and loopback access through SSH only. No new domain or Tailscale listener was installed. Existing telemetry containers, viewer process and public route are unchanged. ADR-020 records the post-merge account decision; the adjacent runbook records live checks and rollback.How it's tested
python3 -m unittest discover -s apps/job_runner -p 'test_*.py': 46 passing tests, including connection closure on commit and rollback and per-template executable scratch. New regressions fail against the merged code.node --test apps/job_runner/*.test.mjs: 31 passing tests, including native PM2 entrypoint execution, heap bounds and the default, empty and custom config-path cases. The new startup regression fails against the merged template.git diff --checkpass.Checklist